Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ir): repr iterables when constructing name of operations #9480

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 30, 2024

Addresses an issue found while fixing #9474 where we didn't use variadic tuple
arguments when constructing the names of ops.

@cpcloud cpcloud added this to the 9.2 milestone Jun 30, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis internals Issues or PRs related to ibis's internal APIs labels Jun 30, 2024
@cpcloud cpcloud force-pushed the fix-duplicate-projections branch 5 times, most recently from 1be3f76 to 36005ea Compare June 30, 2024 12:24
@cpcloud cpcloud changed the title fix(ir): flatten iterables when constructing name, to fix incorrect duplication of names fix(ir): repr iterables when constructing name of operations Jun 30, 2024
@cpcloud cpcloud force-pushed the fix-duplicate-projections branch from b381858 to 6686aba Compare July 1, 2024 13:33
@cpcloud cpcloud requested a review from gforsyth July 1, 2024 13:33
@cpcloud cpcloud force-pushed the fix-duplicate-projections branch from b6e7978 to 3cfeec3 Compare July 1, 2024 14:47
@cpcloud cpcloud enabled auto-merge (squash) July 1, 2024 14:47
@cpcloud
Copy link
Member Author

cpcloud commented Jul 1, 2024

Just a note here: for very complex unnamed expressions, name can be enormous. The solution for now is to not let ibis generate names, and to give things explicit names. Most of the time our APIs make that easy or required, so this case should be relatively rare I think.

@cpcloud cpcloud merged commit f5a541c into ibis-project:main Jul 1, 2024
76 checks passed
@cpcloud cpcloud deleted the fix-duplicate-projections branch July 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis internals Issues or PRs related to ibis's internal APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants